Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old pre-production Koha volumes code #1992

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

kylemhall
Copy link
Member

@kylemhall kylemhall commented Aug 16, 2024

Any libraries using the pre-release version of Koha's item groups ( i.e. volumes ) has since been upgraded past 22.11.
This code should be safe to remove now as it relates to a version of a feature that was never part of community Koha.

In Koha, it is possible to create item groups (i.e. volumes) without attaching items to that group.
If an item group has no items, the volume level hold will be unfillable unless items are added to it at a future time.
For these reasons, it makes sense to filter these empty volumes out.

A possible future enhancement would be to make the display of empty volumes configurable.

Test Plan:
1) Set up an instance of Koha connected to Aspen Discovery
2) Create 10 items, and four item groups on one record
3) Attach 3 items to each of 3 of the item groups
4) Run koha_export.jar
5) Note the empty volume shows in the list of volumes you can place
   holds on
6) Check out this branch
7) Recompile koha_export.jar
8) Repeat step 4
8) Note the empty volume is no longer in the volume pulldown

Closes Aspen-Discovery#1989
Any libraries using the pre-release version of Koha's item groups ( i.e. volumes ) has since been upgraded past 22.11.
This code should be safe to remove now as it relates to a version of a feature that was never part of community Koha.

Test Plan:
No changes in behavior should be noted

Closes Aspen-Discovery#1990
@kylemhall kylemhall changed the title Issue 1990 Remove old pre-production Koha volumes code Aug 16, 2024
Copy link
Member

@mdnoble73 mdnoble73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs release notes

@kylemhall
Copy link
Member Author

@mdnoble73 done!

@mdnoble73 mdnoble73 merged commit 1829f77 into Aspen-Discovery:24.09.00 Aug 21, 2024
1 check failed
@kylemhall kylemhall deleted the issue_1990 branch August 30, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants